Skip to content

Add stack to deployment response resource #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add stack to deployment response resource #4101

wants to merge 6 commits into from

Conversation

@safoinme
Copy link
Contributor

@safoinme safoinme commented Oct 27, 2025

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • IMPORTANT: I made sure that my changes are reflected properly in the following resources:
    • ZenML Docs
    • Dashboard: Needs to be communicated to the frontend team.
    • Templates: Might need adjustments (that are not reflected in the template tests) in case of non-breaking changes and deprecations.
    • Projects: Depending on the version dependencies, different projects might get affected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@safoinme safoinme requested a review from stefannica October 27, 2025 09:43
schustmi
schustmi reviewed Oct 27, 2025
View reviewed changes
src/zenml/models/v2/core/deployment.py
default_factory=list,
title="Curated deployment visualizations.",
)
stack: Optional["StackResponse"] = Field(
Copy link
Contributor

@schustmi schustmi Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for the frontend? Otherwise, in code it would also be quite easy to just fetch it from the snapshot that is already passed as part of the resources.

Copy link
Contributor Author

@safoinme safoinme Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is mainly for front-end

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 27, 2025
@safoinme
Copy link
Contributor Author

safoinme commented Oct 27, 2025 •
edited
Loading

@schustmi does it make sense to do include_metadata=True for the stack so we get full components so it shows up in front-end? or is there an alternative to fetch that in front via ID of stack?

@schustmi
Copy link
Contributor

schustmi commented Oct 27, 2025

@schustmi does it make sense to do include_metadata=True for the stack so we get full components so it shows up in front-end? or is there an alternative to fetch that in front via ID of stack?

@safoinme No I don't think that makes sense. Anything in resources is useful to show in a list of items (e.g. show the stack as a column in the deployment list), but if the frontend needs more information (like the components) on a detail page, it can easily send another request to fetch that.

@safoinme safoinme moved this to In Progress in ZenML Roadmap Oct 27, 2025
@safoinme safoinme added backend Implementations related to the backend planned Planned for the short term and removed backend Implementations related to the backend labels Oct 27, 2025
@safoinme safoinme self-assigned this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schustmi schustmi schustmi approved these changes

@stefannica stefannica Awaiting requested review from stefannica

Assignees

@safoinme safoinme

Labels

internal To filter out internal PRs and issues planned Planned for the short term run-slow-ci

Projects

ZenML Roadmap
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@safoinme @schustmi